Goals
Minimize separate repo tasks
Minimize need to “sync”
Visual design patterns are changed in one place, shared.
Open questions
How do we keep GPS and BTE separate enough that one will not accidentally turn on via a release?
Deploying an app that doesn’t have one of the assets enabled will make it so we can’t request it, IIRC. Apple and Android won’t accept a build that requests permissions it doesn’t have access to.
How would i18n work?
Options
Two RN heads, shared packages with yarn workspaces or lerna
Each “app” contains a distinct react-native root.
Tracking provider is a service in each app
Views are mostly the same, and can be configured with props
“Containers” abstract out the difference between apps, that is… MainContainer listens to the GPS/BTE TrackingService, and reports such “state” down via props to a shared Main component
Main switches between all the core “No known exposure”, “tracking disabled” states.
When functionality is very different, those components remain in the app directory, not in shared. e.g. Share location history might be different.
# existing app
gps/
app/
services/
GpsService.js
views/
# fetch state from service, but pass to shared view
MainContainer.js
ExposureHistoryContainer.js
ShareLocation.js # different, no shared component
App.js
...
android/
ios/
.env
.env.release
# BT app
bte/
app/
services/
GaeService.js
views/
ShareLocation.js # very different, no shared comp
App.js
...
android/
ios/
.env
.env.release
# shared packages via yarn workspaces
packages/
ux/
Button.js
IconButton.js
NavWrapper.js
# shared views, could work. We could have containers around them in app land ^
views/
main/
NoExposure.js
UnknownExposure.js
services/
# would there even be shared services?
# language.js?
// gpd/app/views/MainContainer.js
import { GpsService } from '../services/gps_service';
import { Main } from 'safe-paths-views';
import { Button } from 'safe-paths-core-ux'; // or whatever
export const MainController = () => {
// assume useEffect
const {canTrack, hasExposure} = await GpsService.checkStatus();
return (
<Main canTrack={canTrack} hasExposure={hasExposure} />
);
}
0 Comments